Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Delete operation to include deletion of Artifact Comments #572

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Chris0296
Copy link
Collaborator

@Chris0296 Chris0296 commented Oct 30, 2024

Delete Operation must also delete the Basic resources which represent the comments/approvals of the specified artifact

Spotless also formatted unrelated file.

Copy link

github-actions bot commented Oct 30, 2024

Formatting check succeeded!

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.61%. Comparing base (4e2e534) to head (444398e).
Report is 1 commits behind head on aphl-vsm-temp.

Files with missing lines Patch % Lines
...pencds/cqf/fhir/utility/visitor/DeleteVisitor.java 42.85% 4 Missing ⚠️
...ava/org/opencds/cqf/fhir/utility/ExpandHelper.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             aphl-vsm-temp     #572      +/-   ##
===================================================
- Coverage            72.63%   72.61%   -0.02%     
  Complexity              19       19              
===================================================
  Files                  362      362              
  Lines                18665    18670       +5     
  Branches              2885     2885              
===================================================
+ Hits                 13557    13558       +1     
- Misses                3739     3743       +4     
  Partials              1369     1369              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sliver007 sliver007 merged commit 5450650 into aphl-vsm-temp Oct 30, 2024
6 checks passed
@sliver007 sliver007 deleted the aphl-1257-delete-approvals branch October 30, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants