Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Release extensions when creating a Draft of a Program #576

Open
wants to merge 1 commit into
base: aphl-vsm-temp
Choose a base branch
from

Conversation

Chris0296
Copy link
Collaborator

@Chris0296 Chris0296 commented Nov 1, 2024

When creating a draft of a program, the newly-created drafts owned resource artifacts still have a releaseLabel & releaseDescription extensions and they should not - they’re drafts and haven’t yet been released.

This PR:
-removes 'releaseLabel' & 'releaseDescription' extensions from owned resources when creating a new Draft Program
-update test data and assertions to reflect and validate

-removes 'releaseLabel' & 'releaseDescription' from owned resources when creating a new Draft Program
-update test data and assertions to reflect and validate
Copy link

github-actions bot commented Nov 1, 2024

Formatting check succeeded!

@Chris0296 Chris0296 requested a review from ibaisi November 1, 2024 21:42
Copy link

sonarcloud bot commented Nov 1, 2024

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.62%. Comparing base (5450650) to head (d75fe8a).

Additional details and impacted files
@@               Coverage Diff                @@
##             aphl-vsm-temp     #576   +/-   ##
================================================
  Coverage            72.61%   72.62%           
  Complexity              19       19           
================================================
  Files                  362      362           
  Lines                18670    18672    +2     
  Branches              2885     2885           
================================================
+ Hits                 13558    13561    +3     
  Misses                3743     3743           
+ Partials              1369     1368    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant