Move jars to a separate directory #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
./dist/jars/folder to a new location (./jars/) to keep it from being deleted as part ofpretestwhen thetestscript is run. This keeps the test from re-downloading a fresh copy of the language server jar with every run, which can be incredibly slow (often taking about 30 seconds). Now, the whole test suite completes in about 300ms, making it much more viable to iterate on - something that will be important as we work to increase test coverage.I did consider finding a way to clear out everything in
./dist/exceptjars/, but that turned out to be more involved than should be necessary, so this is cleaner.