Connection manager polish #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added form validation for patient contexts * Added sorting of connections alphabetically * Added confirmation messaging for deleting connections * Added ability to import/export connections * Added connection manager functions to commands palette
|
Pending changes. |
holly-smile
suggested changes
Sep 5, 2024
There was a problem hiding this comment.
Code looks good! A few things:
- If possible, replace or update the "Press 'Enter' to confirm your input" to something specific to the context.
- Hitting "Enter" after that dialog without entering anything, brings up an unpopulated "Edit Connection" dialog, or a "Delete Connection" dialog that does nothing.
- Local connection should be pinned to the top when sorting, as JP suggested.
I'm super impressed by this! Great choice of additions, and great execution as well.
* Update sorting to always show Local Connection at the top * Refactored edit/delete connections commands to show quick pick options * More styling updates to buttons
holly-smile
approved these changes
Sep 7, 2024
…ode-cql into connection-manager-finalize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Connection Manager Polish]