Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS-38628] [Teamscale Maven Plugin] Kotlin Migration #638

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Avanatiker
Copy link
Member

The POM parameters are not yet properly propagated to the lateinit properties.

@cqse-teamscale-io
Copy link

  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/GitCommitUtils.kt:20-24: [Test Gap] Added method getGitHeadRevision has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/GitCommitUtils.kt:32-36: [Test Gap] Added method getHeadCommitFromGitDirectory has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/GitCommitUtils.kt:42-44: [Test Gap] Added method findGitDirectory has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/TeamscaleMojoBase.kt:111-131: [Test Gap] Added method resolveCommitOrRevision has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/TeamscaleMojoBase.kt:141-147: [Test Gap] Added method MavenProject.getExecutionConfigurationDom has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/TeamscaleMojoBase.kt:95-102: [Test Gap] Added method execute has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/tia/ArgLine.kt:124-125: [Test Gap] Added method removePreviousTiaAgent has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/tia/ArgLine.kt:45-51: [Test Gap] Added method createJavaAgentArgument has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/tia/ArgLine.kt:55-72: [Test Gap] Added method applyToMavenProject has not been tested. (view in Teamscale)
  • teamscale-maven-plugin/src/main/kotlin/com/teamscale/maven/tia/ArgLine.kt:116-117: [Test Gap] Added method hasSpringBootPluginEnabled has not been tested. (view in Teamscale)

See other 39 added untested methods.

@Avanatiker
Copy link
Member Author

Request parked until https://github.com/gradlex-org/maven-plugin-development/milestone/13 finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants