Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-41920 move config id validation to ignore order of options #655

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

jveihelmann
Copy link
Contributor

@jveihelmann jveihelmann commented Feb 19, 2025

Addresses issue TS-41920

  • Changes are tested adequately
  • Agent's README.md updated in case of user-visible changes
  • CHANGELOG.md updated
  • Present new features in N&N
  • TGA Tutorial updated
  • TIA Tutorial updated

Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.

@DreierF DreierF enabled auto-merge February 19, 2025 14:06
@cqse-teamscale-io
Copy link

  • agent/src/main/java/com/teamscale/jacoco/agent/PreMain.java:118-169: [Test Gap] Changed method getAndApplyAgentOptions has not been tested. (view in Teamscale)
  • agent/src/main/java/com/teamscale/jacoco/agent/options/AgentOptionsParser.java:110-151: [Test Gap] Changed method parse has not been tested. (view in Teamscale)
  • agent/src/main/java/com/teamscale/jacoco/agent/options/AgentOptionsParser.java:297-387: [Test Gap] Changed method handleAgentOptions has not been tested. (view in Teamscale)
  • agent/src/main/java/com/teamscale/jacoco/agent/options/AgentOptionsParser.java:389-409: [Test Gap] Changed method readConfigFromTeamscale has not been tested. (view in Teamscale)

View all test gaps in Teamscale.

@DreierF DreierF merged commit e42e89a into master Feb 19, 2025
7 checks passed
@DreierF DreierF deleted the ts/41920_config_options_ordering branch February 20, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants