Skip to content

Commit

Permalink
fix(nsis): verbose flag on unix systems (#185)
Browse files Browse the repository at this point in the history
* fix(nsis): verbose flag on unix systems

* lint, fmt
  • Loading branch information
lucasfernog-crabnebula authored Mar 26, 2024
1 parent 5fc726c commit 2f1029b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changes/fix-nsis-on-unix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"cargo-packager": patch
---

Fix bundling NSIS on Linux and macOS failing due to the verbose flag.
8 changes: 4 additions & 4 deletions crates/packager/src/package/nsis/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -538,10 +538,10 @@ fn build_nsis_app_installer(ctx: &Context, nsis_path: &Path) -> crate::Result<Ve

if let Some(level) = config.log_level {
nsis_cmd.arg(match level {
LogLevel::Error => "/V1",
LogLevel::Warn | LogLevel::Info => "/V2",
LogLevel::Debug => "/V3",
_ => "/V4",
LogLevel::Error => "-V1",
LogLevel::Warn | LogLevel::Info => "-V2",
LogLevel::Debug => "-V3",
_ => "-V4",
});
}

Expand Down
2 changes: 2 additions & 0 deletions crates/utils/src/current_exe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ impl StartingBinary {
///
/// Because [`Error`] is not clone-able, it is recreated instead.
pub(super) fn cloned(&self) -> Result<PathBuf> {
// false positive
#[allow(clippy::useless_asref)]
self.0
.as_ref()
.map(Clone::clone)
Expand Down

0 comments on commit 2f1029b

Please sign in to comment.