fix(packager): exit with error if config not found (#195)

* fix(packager): exit with error if config not found * lint * lint * error out with a new Error variant * Update Cargo.lock --------- Co-authored-by: Amr Bashir <[email protected]>
crabnebula-dev · Apr 15, 2024 · 4c4d919 · 4c4d919
1 parent b04332c
commit 4c4d919
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/.changes/error-out-if-no-config.md b/.changes/error-out-if-no-config.md
@@ -0,0 +1,5 @@
+---
+"cargo-packager": patch
+---
+
+Error out if we cannot find a configuration file.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/packager/src/cli/mod.rs b/crates/packager/src/cli/mod.rs
@@ -135,8 +135,8 @@ fn run_cli(cli: Cli) -> Result<()> {
     };
 
     if configs.is_empty() {
-        tracing::debug!("Couldn't detect a valid configuration file or all configurations are disabled! Nothing to do here.");
-        return Ok(());
+        tracing::error!("Couldn't detect a valid configuration file or all configurations are disabled! Nothing to do here.");
+        std::process::exit(1);
     }
 
     let cli_out_dir = cli.out_dir.as_ref().map(dunce::canonicalize).transpose()?;

diff --git a/crates/packager/src/package/app/mod.rs b/crates/packager/src/package/app/mod.rs
@@ -159,7 +159,7 @@ pub(crate) fn package(ctx: &Context) -> crate::Result<Vec<PathBuf>> {
                     .clone()
                     .ok_or_else(|| crate::Error::MissingNotarizeAuthVars)
             })
-            .unwrap_or_else(|| codesign::notarize_auth())
+            .unwrap_or_else(codesign::notarize_auth)
         {
             Ok(auth) => {
                 tracing::debug!("Notarizing {}", app_bundle_path.display());

diff --git a/examples/slint/src/main.rs b/examples/slint/src/main.rs
@@ -1,4 +1,5 @@
 #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")] // hide console window on Windows in release
+#![allow(dead_code)]
 
 slint::include_modules!();