feat: add glob support for icons field (#99)

.changes/glob-icons.md

@@ -0,0 +1,5 @@
+---
+"cargo-packager": "patch"
+---
+
+Add glob patterns support for the icons option in config.

crates/packager/schema.json

@@ -169,7 +169,7 @@
       ]
     },
     "icons": {
-      "description": "The app's icon list.",
+      "description": "The app's icon list. Supports glob patterns.",
       "type": [
         "array",
         "null"

crates/packager/src/config/builder.rs

@@ -131,10 +131,10 @@ impl ConfigBuilder {
     }
 
     /// Sets [`Config::icons`].
-    pub fn icons<I, P>(mut self, icons: I) -> Self
+    pub fn icons<I, S>(mut self, icons: I) -> Self
     where
-        I: IntoIterator<Item = P>,
-        P: Into<PathBuf>,
+        I: IntoIterator<Item = S>,
+        S: Into<String>,
     {
         self.0
             .icons

crates/packager/src/config/mod.rs

@@ -1488,8 +1488,8 @@ pub struct Config {
     pub copyright: Option<String>,
     /// The app's category.
     pub category: Option<AppCategory>,
-    /// The app's icon list.
-    pub icons: Option<Vec<PathBuf>>,
+    /// The app's icon list. Supports glob patterns.
+    pub icons: Option<Vec<String>>,
     /// The file associations
     #[serde(alias = "file-associations", alias = "file_associations")]
     pub file_associations: Option<Vec<FileAssociation>>,
@@ -1653,6 +1653,20 @@ impl Config {
             .map(|b| b.path.file_stem().unwrap().to_string_lossy().into_owned())
             .ok_or_else(|| crate::Error::MainBinaryNotFound)
     }
+
+    /// Returns all icons path.
+    pub fn icons(&self) -> crate::Result<Option<Vec<PathBuf>>> {
+        let Some(patterns) = &self.icons else {
+            return Ok(None);
+        };
+        let mut paths = Vec::new();
+        for pattern in patterns {
+            for icon_path in glob::glob(pattern)? {
+                paths.push(icon_path?);
+            }
+        }
+        Ok(Some(paths))
+    }
 }
 
 #[derive(Debug, Clone)]
@@ -1737,8 +1751,9 @@ impl Config {
     }
 
     #[allow(unused)]
-    pub(crate) fn find_ico(&self) -> Option<PathBuf> {
-        self.icons
+    pub(crate) fn find_ico(&self) -> crate::Result<Option<PathBuf>> {
+        let icon = self
+            .icons()?
             .as_ref()
             .and_then(|icons| {
                 icons
@@ -1750,7 +1765,8 @@ impl Config {
                         })
                     })
             })
-            .map(PathBuf::from)
+            .map(PathBuf::from);
+        Ok(icon)
     }
 
     #[allow(unused)]

crates/packager/src/package/deb/mod.rs

@@ -48,9 +48,8 @@ fn generate_icon_files(config: &Config, data_dir: &Path) -> crate::Result<BTreeS
         ))
     };
     let mut icons_set = BTreeSet::new();
-    if let Some(icons) = &config.icons {
+    if let Some(icons) = config.icons()? {
         for icon_path in icons {
-            let icon_path = PathBuf::from(icon_path);
             if icon_path.extension() != Some(OsStr::new("png")) {
                 continue;
             }

crates/packager/src/package/wix/mod.rs

@@ -519,7 +519,7 @@ fn build_wix_app_installer(ctx: &Context, wix_path: &Path) -> crate::Result<Vec<
     data.insert("app_exe_source", to_json(&main_binary_path));
 
     // copy icon from `settings.windows().icon_path` folder to resource folder near msi
-    if let Some(icon) = config.find_ico() {
+    if let Some(icon) = config.find_ico()? {
         let icon_path = dunce::canonicalize(icon)?;
         data.insert("icon_path", to_json(icon_path));
     }

crates/packager/src/util.rs

@@ -279,16 +279,15 @@ pub(crate) fn is_retina<P: AsRef<Path>>(path: P) -> bool {
 pub fn create_icns_file(out_dir: &Path, config: &crate::Config) -> crate::Result<Option<PathBuf>> {
     use image::GenericImageView;
 
-    if config.icons.as_ref().map(|i| i.len()).unwrap_or_default() == 0 {
+    let icons = config.icons()?;
+    if icons.as_ref().map(|i| i.len()).unwrap_or_default() == 0 {
         return Ok(None);
     }
 
     // If one of the icon files is already an ICNS file, just use that.
-    if let Some(icons) = &config.icons {
+    if let Some(icons) = icons {
         std::fs::create_dir_all(out_dir)?;
-
         for icon_path in icons {
-            let icon_path = PathBuf::from(icon_path);
             if icon_path.extension() == Some(std::ffi::OsStr::new("icns")) {
                 let dest_path = out_dir.join(
                     icon_path
@@ -330,8 +329,8 @@ pub fn create_icns_file(out_dir: &Path, config: &crate::Config) -> crate::Result
     }
 
     let mut images_to_resize: Vec<(image::DynamicImage, u32, u32)> = vec![];
-    if let Some(icons) = &config.icons {
-        for icon_path in icons {
+    if let Some(icons) = config.icons()? {
+        for icon_path in &icons {
             let icon = image::open(icon_path)?;
             let density = if is_retina(icon_path) { 2 } else { 1 };
             let (w, h) = icon.dimensions();