Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix packaging of external binaries #124

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix: fix packaging of external binaries #124

merged 2 commits into from
Jan 8, 2024

Conversation

amr-crabnebula
Copy link
Collaborator

No description provided.

naman-crabnebula
naman-crabnebula approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@naman-crabnebula naman-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external binary issue has been solved on Linux. I successfully compiled on Ubuntu 22.04 LTS as well as Arch Linux.

@amr-crabnebula amr-crabnebula merged commit 2a50c8e into main Jan 8, 2024
23 checks passed
@amr-crabnebula amr-crabnebula deleted the fix/packagin-external-binaries branch January 8, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naman-crabnebula naman-crabnebula naman-crabnebula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amr-crabnebula @naman-crabnebula