Add missing Mach-O magic bytes #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,8 +90,15 @@ pub(crate) fn package(ctx: &Context) -> crate::Result<Vec<PathBuf>> { | |||
| let mut buffer = [0; 4]; | |||
| std::io::Read::read_exact(&mut open_file, &mut buffer)?; | |||
|
|
|||
| const MACH_O_MAGIC_NUMBERS: [u32; 5] = | |||
| [0xfeedface, 0xfeedfacf, 0xcafebabe, 0xcefaedfe, 0xcffaedfe]; | |||
| const MACH_O_MAGIC_NUMBERS: [u32; 5] = [ | |||
There was a problem hiding this comment.
Replace this with [u32; 7]
|
I misinterpreted some debugging results, this isn't necessary, Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #132 introduced, the scanning for Mach-O files to sign was not implemented correctly. It is missing two magic byte combinations which are required for signing core dumps and electron binaries on x86 macos devices. Not sure why, but it seems they have their own magic bytes there