feat(packager): add support to macOS .app bundles #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the DMG PR ready as soon as this gets merged. |
|
Nice, I will get this reviewed and merged asap |
amr-crabnebula
requested changes
Sep 13, 2023
Comment on lines
+8
to
+9
| const KEYCHAIN_ID: &str = "cargo-packager.keychain"; | ||
| const KEYCHAIN_PWD: &str = "cargo-packager"; |
There was a problem hiding this comment.
changed these to be cargo-packager, that should be okay, no?
| // we should use the bundle name (App name) as a MacOS standard. | ||
| // version or platform shouldn't be included in the App name. | ||
| let app_product_name = format!("{}.app", config.product_name); | ||
| let app_bundle_path = config.out_dir().join(&app_product_name); |
There was a problem hiding this comment.
I changed this path so the final bundle is directly under config.out_dir() but I am not sure if this change broke anything, so could you please test this? Ideally all targets operate like this:
config.out_dir/
|_ <target>/
|_ intermediate files needed while building
|_ <another-target>/
|_ intermediate files needed while building
|_ final-packge-file-here
|_ another-final-packge-file-here
|
All good @amr-crabnebula |
amr-crabnebula
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.