-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packager): always show command output, enhance formatting #196
Conversation
Usage of |
I don't think this should be |
if std::env::var_os("CARGO_TERM_COLOR").is_none() { | ||
std::env::set_var("CARGO_TERM_COLOR", "always"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be set by the user invoking the packager? or at least kept as auto
so it automatically detects whether the current terminal has color support or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do not force this there's no colored output at all :(
I think for some commands this can be debug only, but for the |
using error level for stderr is tricky, some CLIs use it for progress output for instance |
alright, I have changed it to always show output of |
It's hard to understand when e.g. a
cargo build
fails because we do not show its output without the--verbose
flag. This PR changes the tracing event level to INFO so it's always available, and enhances the formatting to remove extra fields, dates, and log level.