feat(packager): config for binaries dir #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently cargo-packager expects the
Config::out_dirvalue to contain the binaries to package AND uses it as the output directory. For Rust projects we manually detect the binaries output directory, so it's impossible to use a custom output directory for the packages.This PR adds a
Config::binaries_diroption so you can separate the package output directory and the relative-path-binaries source. With this change, it is possible to runcargo packager ./out/packagerin a Rust project and it'll manually detect the binaries dir while using the provided output directory without crashing or failing to find the binaries.