feat(debian): auto-add an Exec arg (field code) in the .desktop file
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an `{exec_arg}` field to the default `main.desktop` template.
This field is populated by handlebars with a sane default value,
which is based on whether `deep_link_protocols` or `file_associations`
in the `Config` struct have been specified.
This allows an installed Debian package to be invoked by other applications
with URLs or files as arguments, as expected.
The `main.desktop` template previously did not automatically include
an Exec field code even if `deep_link_protocols` or `file_associations`
were set, which would confuse new users who incorrectly expected that
the Debian package would automatically handle links and file associations
upon installation. This change now ensures their expectations are met.
amr-crabnebula
requested changes
Jul 2, 2024
crates/packager/src/config/mod.rs
Outdated
Comment on lines
208
to
211
| /// * "%U", if at least one [Config::deep_link_protocols] was specified. | ||
| /// * This means that your application can accommodate being invoked with multiple URLs. | ||
| /// * "%F", if at least one [Config::file_associations] was specified but no deep link protocols were given, or | ||
| /// * This means that your application can accommodate being invoked with multiple file paths. |
There was a problem hiding this comment.
I would switch the order of these, i.e explain %F first and then %U and should also mention that %U will make file paths into file urls
Co-authored-by: Amr Bashir <[email protected]>
|
oh, huh, I just noticed that when making changes on my mac, the
Edit: saw your other answer; this should be good to go. |
amr-crabnebula
approved these changes
Jul 2, 2024
|
Thanks for your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an
{exec_arg}field to the defaultmain.desktoptemplate. This field is populated by handlebars with a sane default value, which is based on whetherdeep_link_protocolsorfile_associationsin theConfigstruct have been specified.This allows an installed Debian package to be invoked by other applications with URLs or files as arguments, as expected.
The
main.desktoptemplate previously did not automatically include an Exec field code even ifdeep_link_protocolsorfile_associationswere set, which could potentially confuse new users who incorrectly expected that the Debian package would automatically handle links and file associations upon installation. This change now ensures their expectations are met.