fix(dmg): canonicalize path returns from create_icns_file

[jason-crabnebula]

When out-dir is provided but does not exist, create_icns_file() returns a relative path (out/dir/icon.icns). Calling the create-dmg script will change the working dir to out-dir. When copying the volume icon, the icon does not exist at the path (out/dir/out/dir/icon.icns).

[lucasfernog-crabnebula]

@amr-crabnebula shouldn't we create the out-dir upfront instead of making this change? what's your opinion?

[amr-crabnebula]

yeah we should create the out-dir upfront

[jason-crabnebula]

Hmm, it creates the dir before invoking create_icns_file(). Maybe we should canonicalize the new created folder path on line 1800?

cargo-packager/crates/packager/src/config/mod.rs

Lines 1796 to 1801 in 937de61

	} else if self.out_dir.exists() {
	dunce::canonicalize(&self.out_dir).unwrap_or_else(|_| self.out_dir.clone())
	} else {
	std::fs::create_dir_all(&self.out_dir).expect("failed to create output directory");
	self.out_dir.clone()
	}

[amr-crabnebula]

@jason-crabnebula sounds good