-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pacman): enclose directory paths in PKGBUILD
in double quotes
#264
fix(pacman): enclose directory paths in PKGBUILD
in double quotes
#264
Conversation
This ensures that paths with spaces on the target machine are properly preserved during pacman's installation of the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, could you add a change file in .changes
directory?
something like this:
---
"cargo-packager": patch
"@crabnebula/packager": patch
---
Fix `pacman` package failing to install when source directory contained whitespace.
I tried pushing the change file myself but I couldn't 😢 lacking permissions on your repo |
oh shoot, sorry guys I completely forgot about this PR in the hecticness of so much travel. Will push shortly! |
done! thanks for the reminder, and my apologies for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally we require that commits are signed, but in the interest of approving your contribution I will relax the requirements this time.
thanks, will keep that in mind for my next contribution. |
This ensures that paths with spaces on the target machine are properly preserved during pacman's installation of the package.
Context: some users of our Moxin app that was packaged for Arch Linux using
cargo-packager
reported that their pacman install command was failing due to paths containing whitespace.Thanks to @cassaundra for proposing this fix and confirming that it works.