Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacman): enclose directory paths in PKGBUILD in double quotes #264

Conversation

kevinaboos
Copy link
Contributor

This ensures that paths with spaces on the target machine are properly preserved during pacman's installation of the package.

Context: some users of our Moxin app that was packaged for Arch Linux using cargo-packager reported that their pacman install command was failing due to paths containing whitespace.
Thanks to @cassaundra for proposing this fix and confirming that it works.

This ensures that paths with spaces on the target machine
are properly preserved during pacman's installation of the package.
Copy link
Collaborator

@amr-crabnebula amr-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, could you add a change file in .changes directory?

something like this:

---
"cargo-packager": patch
"@crabnebula/packager": patch
---

Fix `pacman` package failing to install when source directory contained whitespace.

@lucasfernog-crabnebula
Copy link
Member

I tried pushing the change file myself but I couldn't 😢 lacking permissions on your repo

@kevinaboos
Copy link
Contributor Author

oh shoot, sorry guys I completely forgot about this PR in the hecticness of so much travel. Will push shortly!

@kevinaboos
Copy link
Contributor Author

done! thanks for the reminder, and my apologies for the delay.

Copy link
Contributor

@denjell-crabnebula denjell-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we require that commits are signed, but in the interest of approving your contribution I will relax the requirements this time.

@kevinaboos
Copy link
Contributor Author

Normally we require that commits are signed, but in the interest of approving your contribution I will relax the requirements this time.

thanks, will keep that in mind for my next contribution.

@amr-crabnebula amr-crabnebula merged commit fea80d5 into crabnebula-dev:main Oct 10, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants