feat(macos): add team_id option for apple notarization #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of tauri-apps/tauri#7775 Co-authored-by: Trey Smith <[email protected]> Co-authored-by: Lucas Nogueira <[email protected]>
Port of tauri-apps/tauri#7934 Co-authored-by: Jason Tsai <[email protected]> Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
Port of tauri-apps/tauri#7972 Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
amr-crabnebula
previously approved these changes
Oct 19, 2023
lucasfernog-crabnebula
requested changes
Oct 20, 2023
Co-authored-by: Lucas Nogueira <[email protected]>
jason-crabnebula
requested review from
amr-crabnebula and
lucasfernog-crabnebula
amr-crabnebula
approved these changes
Oct 23, 2023
lucasfernog-crabnebula
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of tauri-apps/tauri#7775
Port of tauri-apps/tauri#7934
Port of tauri-apps/tauri#7972
Made some changes to the origin PR's error handling since we have refactored them to the
enum ErrorTested the notarization process on my Macbook. But it would be nice if someone could double-check it again 👀