feat: port tauri updater #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog-crabnebula
force-pushed
the
feat/updater
branch
from
ec46694
to
038467b
Compare
lucasfernog-crabnebula
force-pushed
the
feat/updater
branch
from
7c3a987
to
3cbed63
Compare
| @@ -154,7 +154,10 @@ pub fn sign_outputs( | |||
| let zip = path.with_extension(extension); | |||
| let dest_file = util::create_file(&zip)?; | |||
| let gzip_encoder = libflate::gzip::Encoder::new(dest_file)?; | |||
| util::create_tar_from_dir(path, gzip_encoder)?; | |||
| let writer = util::create_tar_from_dir(path, gzip_encoder)?; | |||
There was a problem hiding this comment.
I checked this function, why isn't it using tar's append methods? seems like a custom implementation instead of something like https://docs.rs/tar/latest/tar/struct.Builder.html#method.append_dir_all
There was a problem hiding this comment.
not sure what you mean by that, it is using append_data to in order to set the uid and gid
|
I have no idea why the Windows test was passing yesterday and now it's broken. I only touched Linux stuff 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.