Skip to content

Commit

Permalink
Merge pull request #272 from craftcms/bugfix/268-dropdown-height
Browse files Browse the repository at this point in the history
set max dropdown height
  • Loading branch information
brandonkelly authored Aug 15, 2024
2 parents 9d4d8b0 + 62444e7 commit 1372a53
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- CKEditor configs created via the `ckeditor/convert` command now allow modifying HTML attributes, classes, and styles within the source view, if the Redactor config included the `html` button. ([#264](https://github.com/craftcms/ckeditor/pull/264), [#263](https://github.com/craftcms/ckeditor/issues/263))
- Added `craft\ckeditor\events\ModifyConfigEvent::$toolbar`. ([#233](https://github.com/craftcms/ckeditor/pull/233))
- Fixed a bug where code blocks created by a Redactor field only had `<pre>` tags with no `<code>` tags inside them. ([#258](https://github.com/craftcms/ckeditor/issues/258))
- Fixed a bug where dropdown menus didn’t have a maximum height. ([#268](https://github.com/craftcms/ckeditor/issues/268))

## 3.8.3 - 2024-03-28

Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/ckeditor/dist/css/ckeditor5-craftcms.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/web/assets/ckeditor/src/ckeditor5-craftcms.css
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ a.ck.ck-button:focus {
border: none !important;
}

.ck.ck-dropdown__panel-visible {
max-height: 50vh;
overflow-y: scroll;
}

.ck.ck-dropdown .ck-button.ck-dropdown__button.ck-on {
border-bottom-left-radius: var(--ck-border-radius) !important;
border-bottom-right-radius: var(--ck-border-radius) !important;
Expand Down

0 comments on commit 1372a53

Please sign in to comment.