Merge pull request #15878 from craftcms/bugfix/15876-source-selection…

…-via-keyboard fixes error that prevents source from being selected via keyboard
craftcms · Oct 10, 2024 · 68557cb · 68557cb
2 parents 9076f0b + 62efeec
commit 68557cb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Fixed a styling issue with Color field inputs. ([#15868](https://github.com/craftcms/cms/issues/15868))
 - Fixed a deprecation error. ([#15873](https://github.com/craftcms/cms/issues/15873))
+- Fixed a bug where element sources weren’t keyboard-selectable. ([#15876](https://github.com/craftcms/cms/issues/15876))
 
 ## 5.4.7.1 - 2024-10-09
 

diff --git a/src/web/assets/cp/dist/cp.js b/src/web/assets/cp/dist/cp.js
diff --git a/src/web/assets/cp/dist/cp.js.map b/src/web/assets/cp/dist/cp.js.map
diff --git a/src/web/assets/cp/src/js/BaseElementIndex.js b/src/web/assets/cp/src/js/BaseElementIndex.js
@@ -3860,8 +3860,8 @@ const SourceNav = Garnish.Base.extend(
 
       if (
         (keyCode === Garnish.RETURN_KEY || keyCode === Garnish.SPACE_KEY) &&
-        !ev.shiftKey &&
-        !Garnish.isCtrlKeyPressed(ev)
+        !event.shiftKey &&
+        !Garnish.isCtrlKeyPressed(event)
       ) {
         event.preventDefault();
         this.selectItem(event.target);