Sort by ID by default

craftcms · Nov 22, 2024 · bce2bdc · bce2bdc
1 parent 65cca80
commit bce2bdc
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Element indexes now sort by ID by default, for sources that don’t define a default sort option.
 - Fixed a bug where element indexes were sorting by the first sortable attribute alphabetically by default, rather than the first sortable attribute defined by the element type.
 
 ## 4.13.2 - 2024-11-19

diff --git a/src/base/Element.php b/src/base/Element.php
@@ -1259,6 +1259,12 @@ public static function sortOptions(): array
     {
         $sortOptions = static::defineSortOptions();
 
+        // Make sure ID is listed first
+        $sortOptions = [
+            'id' => Craft::t('app', 'ID'),
+            ...ArrayHelper::without($sortOptions, 'id'),
+        ];
+
         // Give plugins a chance to modify them
         $event = new RegisterElementSortOptionsEvent([
             'sortOptions' => $sortOptions,

diff --git a/src/elements/Asset.php b/src/elements/Asset.php
@@ -563,7 +563,6 @@ protected static function defineSortOptions(): array
                 'orderBy' => 'dateUpdated',
                 'defaultDir' => 'desc',
             ],
-            'id' => Craft::t('app', 'ID'),
             'width' => Craft::t('app', 'Width'),
             'height' => Craft::t('app', 'Height'),
         ];

diff --git a/src/elements/Category.php b/src/elements/Category.php
@@ -322,7 +322,6 @@ protected static function defineSortOptions(): array
                 'orderBy' => 'dateUpdated',
                 'defaultDir' => 'desc',
             ],
-            'id ' => Craft::t('app', 'ID'),
         ];
     }
 

diff --git a/src/elements/Entry.php b/src/elements/Entry.php
@@ -552,7 +552,6 @@ protected static function defineSortOptions(): array
                 'orderBy' => 'dateUpdated',
                 'defaultDir' => 'desc',
             ],
-            'id' => Craft::t('app', 'ID'),
         ];
     }
 

diff --git a/src/elements/User.php b/src/elements/User.php
@@ -396,7 +396,6 @@ protected static function defineSortOptions(): array
                     'orderBy' => 'dateUpdated',
                     'defaultDir' => 'desc',
                 ],
-                'id' => Craft::t('app', 'ID'),
             ];
         } else {
             $attributes = [
@@ -420,7 +419,6 @@ protected static function defineSortOptions(): array
                     'orderBy' => 'dateUpdated',
                     'defaultDir' => 'desc',
                 ],
-                'id' => Craft::t('app', 'ID'),
             ];
         }