Merge branch 'v4' into develop

# Conflicts: # CHANGELOG.md # src/gateways/PaymentIntents.php
craftcms · Mar 28, 2024 · 8b74363 · 8b74363
2 parents c956a81 + 332a55b
commit 8b74363
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -3,6 +3,7 @@ on:
   workflow_dispatch:
   push:
     branches:
+      - v4
       - develop
       - main
   pull_request:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,9 +1,17 @@
 # Release Notes for Stripe for Craft Commerce
 
+## Unreleased
+
+- Fixed a bug where floating point rounding precision could cause payments/refunds to fail. ([#296](https://github.com/craftcms/commerce-stripe/pull/296))
+
 ## 5.0.0
 
 - Stripe now requires Craft Commerce 5.0.0-beta.1 or later.
 
+## 4.1.2.1 - 2024-03-28
+
+- Fixed a bug where floating point precision could cause payments/refunds to fail. ([#296](https://github.com/craftcms/commerce-stripe/pull/296))
+
 ## 4.1.2 - 2024-03-25
 
 - Fixed a bug where redirects could break when adding a new payment source. ([#259](https://github.com/craftcms/commerce-stripe/issues/259), [#289](https://github.com/craftcms/commerce-stripe/issues/289))

diff --git a/src/gateways/PaymentIntents.php b/src/gateways/PaymentIntents.php
@@ -288,7 +288,7 @@ public function refund(Transaction $transaction): RequestResponseInterface
             try {
                 $request = [
                     'charge' => $transaction->reference,
-                    'amount' => $transaction->paymentAmount * (10 ** $currencyService->getSubunitFor($currency)),
+                    'amount' => (int) bcmul($transaction->paymentAmount, 10 ** $currencyService->getSubunitFor($currency)),
                 ];
                 $refund = $this->getStripeClient()->refunds->create($request);
 
@@ -304,7 +304,7 @@ public function refund(Transaction $transaction): RequestResponseInterface
             if ($stripePaymentIntent->status == 'succeeded') {
                 $refund = $this->getStripeClient()->refunds->create([
                     'payment_intent' => $stripePaymentIntent->id,
-                    'amount' => $transaction->paymentAmount * (10 ** $currencyService->getSubunitFor($currency)),
+                    'amount' => (int) bcmul($transaction->paymentAmount, 10 ** $currencyService->getSubunitFor($currency)),
                 ]);
 
                 return $this->createPaymentResponseFromApiResource($refund);
@@ -640,7 +640,7 @@ protected function authorizeOrPurchase(Transaction $transaction, PaymentIntentFo
         }
 
         // Normalized amount for Stripe into minor units
-        $amount = $transaction->paymentAmount * (10 ** $currencyService->getSubunitFor($currency));
+        $amount = (int) bcmul($transaction->paymentAmount, 10 ** $currencyService->getSubunitFor($currency));
 
         /** @var PaymentIntentForm $form */
         if ($form->paymentFormType == self::PAYMENT_FORM_TYPE_CHECKOUT) {