-
Notifications
You must be signed in to change notification settings - Fork 139
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename mapping from parent to parentId
The attribute `parentId` is used in Craft to signify the value of the parent element, if any. Therefore, the mapping handle should also be `parentId`. This patch changes the mapping handle from `parent` into `parentId`. This allows the comparison code to properly verify that an existing parent already exists. Without this patch the current comparison will use the `parent` property that does not exist in a Craft entry. This should have been `parentId` which does exist. Note that this patch is *not* backwards compatible, all imports that have been configured with a parent using handle `parent` must reconfigure the parent so it uses the renamed handle `parentId`. Perhaps it is worth the time to create a migration for this?
- Loading branch information
1 parent
eaac8e3
commit 4a673af
Showing
4 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters