Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/62 webhook settings #63

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Bugfix/62 webhook settings #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ba58b2
don't parse webhook id and signing secret when displaying on the page
i-just Nov 26, 2024
72d8429
updated changelog
i-just Nov 26, 2024
22a4cb3
Merge branch '1.x' into bugfix/62-webhook-settings
i-just Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

- Fixed a bug where the products index page gave impression that it was possible to sort by Link. ([#59](https://github.com/craftcms/stripe/issues/59))
- Fixed a bug where, in certain cases, it was possible to access a Subscription element in a slideout without having permission to access the Stripe plugin. ([#61](https://github.com/craftcms/stripe/pull/61))
- Fixed a bug where the “Sync from Stripe” user menu item was shown even if user didn't permission to access the Stripe plugin. ([#61](https://github.com/craftcms/stripe/pull/61))
- Fixed a bug where the “Sync from Stripe” user menu item was shown even if user didn't have permission to access the Stripe plugin. ([#61](https://github.com/craftcms/stripe/pull/61))
- Fixed a bug where the Webhook Signing Secret and ID were showing as parsed on the Webhooks page. ([#62](https://github.com/craftcms/stripe/issues/62))

## 1.3.0 - 2024-11-19

Expand Down
4 changes: 2 additions & 2 deletions src/controllers/WebhooksController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ public function actionEdit(): YiiResponse

$webhookInfo = [];
$hasWebhook = true;
$webhookId = App::parseEnv($webhookRecord->webhookId);
$webhookSigningSecret = App::parseEnv($webhookRecord->webhookSigningSecret);
$webhookId = $webhookRecord->webhookId;
$webhookSigningSecret = $webhookRecord->webhookSigningSecret;

if (!empty($webhookId)) {
try {
Expand Down
Loading