[develop] Update docs URLs #4294
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumerjabri
reviewed
Dec 12, 2024
rart
approved these changes
Dec 12, 2024
sumerjabri
approved these changes
Dec 17, 2024
|
@jvega190 please link the new ticket to remove the old files. |
sumerjabri
requested changes
Feb 20, 2025
There was a problem hiding this comment.
The READMEs have changed, see the PR: https://github.com/craftercms/studio-ui/pull/4358/files
| @@ -68,7 +68,7 @@ export function AboutCrafterCMSView() { | |||
| values={{ | |||
| a: (msg) => ( | |||
| <Link | |||
| href={`https://docs.craftercms.org/en/${env.packageVersion?.substr( | |||
| href={`https://craftercms.com/docs/${env.packageVersion?.substr( | |||
There was a problem hiding this comment.
This won't work. Docs now are /docs/{major}.
This must also take into account a major version of more than 1 char, for example version 10.
| @@ -85,7 +85,7 @@ function LauncherGlobalNav(props: LauncherGlobalNavProps) { | |||
| <LauncherTile | |||
| title={formatMessage(messages.docs)} | |||
| icon={{ id: 'craftercms.icons.Docs' }} | |||
| link={`https://docs.craftercms.org/en/${getSimplifiedVersion(version)}/index.html`} | |||
| link={`https://craftercms.com/docs/${getSimplifiedVersion(version)}/index.html`} | |||
There was a problem hiding this comment.
This also won't work. See the new method Roy added on 2/20/2025.
| @@ -212,7 +212,7 @@ function QuickCreateSection(props: QuickCreateSectionProps) { | |||
| {version && ( | |||
| <Button | |||
| size="small" | |||
| href={`https://docs.craftercms.org/en/${version}/developers/content-modeling.html#setting-up-quick-create`} | |||
| href={`https://craftercms.com/docs/${version}/by-role/developer/common/content-modeling/content-modeling.html#quick-create`} | |||
| @@ -533,17 +533,17 @@ export const dragAndDropMessages = defineMessages({ | |||
| contentTypeNotFound: { | |||
| id: 'dragAndDropMessages.contentTypeNotFound', | |||
| defaultMessage: | |||
| 'The content type id was not found in your template. Drag and drop will be impaired. More info at docs.craftercms.org/en/3.1/system-administrators/upgrade/index.html.' | |||
| 'The content type id was not found in your template. Drag and drop will be impaired. More info at craftercms.com/docs/3.1/system-administrators/upgrade/index.html.' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket reference or full description of what's in the PR
Update docs URLs