refactored action designators and added orm test cases #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsch420
requested changes
Jan 19, 2024
# Conflicts: # examples/intro.ipynb # src/pycram/designator.py # src/pycram/designators/action_designator.py # test/test_local_transformer.py
tomsch420
requested changes
Jan 24, 2024
tomsch420
approved these changes
Jan 26, 2024
Tigul
requested changes
Jan 26, 2024
| """ | ||
| Helper method for internal usage only. | ||
| This method is to be overwritten instead of the execute method. | ||
| """ | ||
| pass | ||
|
|
||
| def execute(self, designator: MotionDesignatorDescription.Motion) -> Any: |
There was a problem hiding this comment.
Why change the typing? Process Modules should still only accept MotionDesignators
There was a problem hiding this comment.
Yes, you are right. But importing the new BaseMotion in order to use it for type hinting leads to circular imports, since it is located in the motion_designator file and the motions themselves need the ProcessModuleManager. Removing the type hint is not fancy, but I didn't see an easy way to solve that problem
Tigul
approved these changes
Feb 5, 2024
artnie
pushed a commit
to artnie/pycram
that referenced
this pull request
Aug 16, 2024
[Tests] adjusted test cases of language to reflect changes made for RetryMonitor
mkhoshnam
pushed a commit
to mkhoshnam/pycram
that referenced
this pull request
Nov 26, 2024
refactored action designators and added orm test cases
mkhoshnam
pushed a commit
to mkhoshnam/pycram
that referenced
this pull request
Nov 26, 2024
[Tests] adjusted test cases of language to reflect changes made for RetryMonitor
mkhoshnam
pushed a commit
to mkhoshnam/pycram
that referenced
this pull request
Nov 26, 2024
[Tests] adjusted test cases of language to reflect changes made for RetryMonitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.