Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cutting-Action] Initial Implementation of Cutting Action #132

Closed
wants to merge 12 commits into from

Conversation

sunava
Copy link
Collaborator

@sunava sunava commented Jan 22, 2024

Overview
This pull request introduces the first draft of the Cutting Action feature, an essential component of our robotic automation system. The present version of the implementation successfully incorporates fundamental functionalities for both slicing and halving actions. Additionally, it includes tests for both the Action and ORM aspects. I have also locally verified the documentation.

PickUpAction -> deleted not used variables and comments

Key Features and Progress

  1. Basic Cutting Actions: The code now supports two primary cutting techniques: slicing and halving. These methods can be applied to objects as specified in the Cutting Action design.

  2. Object and Tool Designation: The implementation allows for the designation of objects to be cut and the tools to be used for cutting.

  3. Arm Selection: The feature supports specifying which robotic arm to use for the cutting action.

Current Limitations and Future Enhancements
While this initial version lays the groundwork for more complex cutting actions, it's important to note that it is still in the early stages of development. Key areas for future development include:

  1. Enhanced Cutting Techniques: Additional cutting techniques and more advanced calculations to handle a wider range of cutting scenarios.
  2. Accuracy Improvements: Refinements in object dimension calculations and cutting precision.
  3. The resolver/queries are there since we do not have a correct interface yet, this was discussed with @tomsch420 an @Tigul that it should stay like this or now, till we define a new interface.

@sunava sunava requested a review from tomsch420 January 22, 2024 10:18
Copy link
Collaborator

@tomsch420 tomsch420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where sparql testcase?

demos/pycram_manipulation_actions/cutting-demo.py Outdated Show resolved Hide resolved
demos/pycram_manipulation_actions/cutting-demo.py Outdated Show resolved Hide resolved
demos/pycram_manipulation_actions/cutting-demo.py Outdated Show resolved Hide resolved
demos/pycram_manipulation_actions/cutting-demo.py Outdated Show resolved Hide resolved
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
src/pycram/resolver/action/cutting.py Outdated Show resolved Hide resolved
src/pycram/resolver/action/cutting.py Outdated Show resolved Hide resolved
src/pycram/resolver/action/cutting.py Outdated Show resolved Hide resolved
test/plans/cutting.py Outdated Show resolved Hide resolved
@sunava sunava requested a review from tomsch420 January 22, 2024 11:54
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tomsch420 tomsch420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomsch420
Copy link
Collaborator

There is a workflow problem @Tigul , can you have a look?

@Tigul
Copy link
Collaborator

Tigul commented Mar 27, 2024

As discussed in the meeting I'll close this PR for now

@Tigul Tigul closed this Mar 27, 2024
@sunava sunava deleted the cutting-designator branch August 17, 2024 13:31
@sunava sunava restored the cutting-designator branch August 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants