-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cutting-Action] Initial Implementation of Cutting Action #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsch420
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where sparql testcase?
…to write test for code that will be changed completly.
tomsch420
requested changes
Jan 22, 2024
tomsch420
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There is a workflow problem @Tigul , can you have a look? |
As discussed in the meeting I'll close this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces the first draft of the Cutting Action feature, an essential component of our robotic automation system. The present version of the implementation successfully incorporates fundamental functionalities for both slicing and halving actions. Additionally, it includes tests for both the Action and ORM aspects. I have also locally verified the documentation.
PickUpAction -> deleted not used variables and comments
Key Features and Progress
Basic Cutting Actions: The code now supports two primary cutting techniques: slicing and halving. These methods can be applied to objects as specified in the Cutting Action design.
Object and Tool Designation: The implementation allows for the designation of objects to be cut and the tools to be used for cutting.
Arm Selection: The feature supports specifying which robotic arm to use for the cutting action.
Current Limitations and Future Enhancements
While this initial version lays the groundwork for more complex cutting actions, it's important to note that it is still in the early stages of development. Key areas for future development include: