Ontology to pycram objects #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsch420
requested changes
Sep 3, 2024
| @@ -813,3 +874,60 @@ def reason(self, world: OntologyWorld = None, use_pellet_reasoner: bool = True) | |||
| return False | |||
| rospy.loginfo(f"{reasoner_name} reasoning finishes!") | |||
| return True | |||
|
|
|||
There was a problem hiding this comment.
Please also provide tests for such methods. Furthermore stick to the RST docstrings.
tomsch420
requested changes
Sep 6, 2024
src/pycram/ontology/ontology.py
Outdated
| Returns: | ||
| conceptIRI: an IRI string. If the input conceptName is already an IRI form, conceptIRI = conceptName. | ||
| :param conceptName: a string containing a possibly shortened concept name | ||
| :type conceptName: str |
There was a problem hiding this comment.
types are not needed since they are annotated in the method signature
test/test_ontology.py
Outdated
| @@ -69,7 +71,9 @@ def remove_sql_file(cls, sql_filepath: str): | |||
| if os.path.exists(sql_journal_filepath): | |||
| os.remove(sql_journal_filepath) | |||
|
|
|||
| @unittest.skipUnless(True, 'never skip') | |||
There was a problem hiding this comment.
this line does nothing. Remove it
test/test_ontology.py
Outdated
| @@ -303,6 +307,52 @@ def test_ontology_save(self): | |||
| self.assertTrue(self.ontology_manager.save(owl_filepath)) | |||
| self.assertTrue(Path(owl_filepath).is_file()) | |||
| self.assertTrue(Path(sql_filepath).is_file()) | |||
|
|
|||
| @unittest.skipUnless(True, 'Never skip') | |||
Tadinu
reviewed
Sep 6, 2024
| @@ -116,7 +119,7 @@ def test_loaded_ontologies(self): | |||
| self.assertIsNotNone(self.main_ontology) | |||
| self.assertTrue(self.main_ontology.loaded) | |||
| if self.ontology_manager.main_ontology_iri is SOMA_ONTOLOGY_IRI or \ | |||
| self.ontology_manager.main_ontology_iri is SOMA_HOME_ONTOLOGY_IRI: | |||
| self.ontology_manager.main_ontology_iri is SOMA_DFL_ONTOLOGY_IRI: | |||
There was a problem hiding this comment.
Suggested change
| self.ontology_manager.main_ontology_iri is SOMA_DFL_ONTOLOGY_IRI: | |
| self.ontology_manager.main_ontology_iri is SOMA_HOME_ONTOLOGY_IRI or \ | |
| self.ontology_manager.main_ontology_iri is SOMA_DFL_ONTOLOGY_IRI: |
Tadinu
reviewed
Sep 6, 2024
tomsch420
approved these changes
Sep 17, 2024
|
Closing this due to inactivity |
|
Ping. Inactivity because I wasn't sure what to do. Were there any changes requested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, but started a pull request to draw attention to this.
TODOs: