Fix missing import and error in tf_broadcaster #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsch420
reviewed
Sep 6, 2024
| @@ -78,8 +79,8 @@ def _publish_pose(self, child_frame_id: str, pose: Pose, static=False) -> None: | |||
| frame_id = pose.frame | |||
| if frame_id != child_frame_id: | |||
| tf_stamped = pose.to_transform(child_frame_id) | |||
| tf_stamped.frame = self.projection_namespace + "/" + tf_stamped.frame | |||
| tf_stamped.child_frame_id = self.projection_namespace + "/" + tf_stamped.child_frame_id | |||
| tf_stamped.frame = self.projection_namespace.name + "/" + tf_stamped.frame | |||
There was a problem hiding this comment.
isnt os.path.join nicer here?
There was a problem hiding this comment.
Not really the scope of this PR, since this is only fixing a bug, but tried it nevertheless. os.path.join behaves differently depending on the platform. No problem if we are always on Linux with this. I could add "/".join(...) though.
There was a problem hiding this comment.
Bug fixes are also required to be as clean as possible.
The question was more If for another os than Linux ghe rostopic still has "/" as seperator or If eg on the seperator will be ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an error here. Since the property projection_namespace is now of type ExecutionType it cannot be concatenated with a string anymore. So we can take the name for that.