Fts real robot #230
Open
Fts real robot #230
+194
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsch420
requested changes
Nov 28, 2024
|
|
||
| class CustomFilter: | ||
| """ | ||
| Abstract class to ensure that every supported filter needs to implement the filter method |
There was a problem hiding this comment.
can the class name also be filter?
| """ | ||
|
|
||
| @abstractmethod | ||
| def filter(self, data): |
|
|
||
| def __init__(self, order=4, cutoff=10, fs=60): | ||
| self.order = order | ||
| self.cutoff = cutoff |
There was a problem hiding this comment.
documentation of params
| """ | ||
|
|
||
| self.robot_name = robot_name | ||
| self.filter_config = filter_config |
There was a problem hiding this comment.
declare the variables as class variables and document them there
|
|
||
| self.__setup() | ||
|
|
||
| def __setup(self): |
There was a problem hiding this comment.
double underscore methods usually have a meaning of "super private please do never access this method from any other file". Is this intended?
| self.prev_values.pop(0) | ||
|
|
||
| if self.debug: | ||
| print( |
There was a problem hiding this comment.
use the debug logging here instead of printing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[fts] custom filter Butterworth for fts for real robot
tested on hsr and donbot