Skip to content

Commit

Permalink
remove comment re ARM on windows (#173)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevaundray authored Aug 13, 2024
1 parent e175ccd commit 7d5dbe4
Showing 1 changed file with 1 addition and 22 deletions.
23 changes: 1 addition & 22 deletions .github/workflows/release-node-bindings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,28 +182,7 @@ jobs:
if: matrix.settings.target == 'x86_64-pc-windows-msvc'
run: yarn test
working-directory: bindings/node
# TODO: Its kind of hard to test windows on arm64 w yarn
# The approach of using linaro/wine-arm64 is the most promising
# We can add it back after some debugging
# - name: Test bindings (Windows ARM64)
# if: matrix.settings.target == 'aarch64-pc-windows-msvc'
# uses: addnab/docker-run-action@v3
# with:
# image: linaro/wine-arm64
# options: '-v ${{ github.workspace }}:/build -w /build'
# run: |
# echo "Download node windows-arm64"
# NODE_VERSION=20.0.0
# wget -q https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-win-arm64.zip
# unzip -q node-*.zip
# mv node-*-win-arm64 /node

# cd bindings/node
# echo "Run tests"
# wine-arm64 /node/node.exe --version
# wine-arm64 /node/npm.cmd install -g yarn
# wine-arm64 /node/yarn.cmd install
# wine-arm64 /node/yarn.cmd test
# ARM on windows is not tested

publish:
name: Publish
Expand Down

0 comments on commit 7d5dbe4

Please sign in to comment.