Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove TODO in acceptable_num_block_erasures #180

Merged
merged 1 commit into from
Aug 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cryptography/erasure_codes/src/reed_solomon.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ impl ReedSolomon {
}
/// Returns the maximum number of block erasures indices that can be missing
/// before we are not able to recover the message.
///
/// Note: This can also be computed by doing block_size / expansion_factor
pub fn acceptable_num_block_erasures(&self) -> usize {
// TODO Note: We could compute this as self.block_size / expansion_factor
self.acceptable_num_random_erasures() / self.num_blocks
}

Expand Down
Loading