Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove TODO regarding unecessary serialization of points #187

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: remove TODO regarding unecessary serialization of points #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cryptography/kzg_multi_open/src/fk20/verifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,6 @@ impl FK20Verifier {
//
// We compute one challenge `r` using fiat-shamir and the rest are powers of `r`
// This is safe since 1, X, X^2, ..., X^n of a variable X are linearly independent (ie there is no non-trivial linear combination that equals zero)
//
// TODO: Because this method takes in G1Points and not their serialized form, there is a roundtrip that happens
// TODO: when we serialize the point for fiat shamir. (I'm leaving this TOOD here until we benchmark the diff)
let r = compute_fiat_shamir_challenge(
&self.opening_key,
deduplicated_commitments,
Expand Down
Loading