chore: Initial impl for KZG10 #234
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #162 -- one can use this branch to check that the difference in using monomial form is actually negligible while it results in much simpler code |
kevaundray
commented
Aug 16, 2024
Comment on lines
21
to
31
| // Bit reverse the polynomial and interpolate it. | ||
| // | ||
| // The bit-reversal is an artifact of a feature we want to maintain | ||
| // when we use FK20. | ||
| let mut poly_lagrange = polynomial_lagrange.to_vec(); | ||
| reverse_bit_order(&mut poly_lagrange); | ||
| let polynomial_coeff = domain.ifft_scalars(poly_lagrange); | ||
|
|
||
| let quotient_poly = divide_by_linear(&polynomial_coeff, input_point); | ||
| let quotient_commitment = commit_key.commit_g1(quotient_poly.as_slice()); | ||
| let claimed_evaluation = poly_eval(&polynomial_coeff, &input_point); |
There was a problem hiding this comment.
None of these methods are actually new -- they are all a part of eip7594 specs, so in a way this does not add any new complexity
There was a problem hiding this comment.
- divide_by_linear is a simpler version of
divide_polynomialcoeffwhere b is a linear polynomial - poly_eval is
evaluate_polynomial_coeff - commit_g1 is g1_lincomb
kevaundray
commented
Aug 16, 2024
| blst = { version = "0.3", default-features = false } | ||
| blst = { version = "0.3", default-features = false, features = ["no-threads"] } |
There was a problem hiding this comment.
This would usually be controlled by the threadpool, but since its not been integrated, I just turn off all threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an initial impl for some of the methods needed in Deneb, however we compute the quotient commitment using the "conventional" strategy of commiting to the quotient polynomial in monomial form.