Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Miscellaneous optimizations #239

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kevaundray
Copy link
Contributor

This makes the BatchToeplitz operations parallelized and also makes the fft parallelized and also iterative

@kevaundray
Copy link
Contributor Author

This PR is mainly being used to figure out the magnitude to which parallelism helps -- if we want significant improvements, it will need to be in the MSM algorithm

@kevaundray
Copy link
Contributor Author

Results -- baseline is single threaded master:

computing cells_and_kzg_proofs - NUM_THREADS: Single
                        time:   [180.78 ms 181.35 ms 182.08 ms]
                        change: [-10.891% -10.454% -10.017%] (p = 0.00 < 0.05)
                        Performance has improved.

computing cells_and_kzg_proofs - NUM_THREADS: Multi(4)
                        time:   [57.467 ms 57.642 ms 57.840 ms]
                        change: [-72.102% -71.859% -71.645%] (p = 0.00 < 0.05)
                        Performance has improved.

computing cells_and_kzg_proofs - NUM_THREADS: Multi(8)
                        time:   [40.380 ms 40.771 ms 41.192 ms]
                        change: [-81.162% -80.477% -79.991%] (p = 0.00 < 0.05)
                        Performance has improved.

computing cells_and_kzg_proofs - NUM_THREADS: Multi(16)
                        time:   [43.413 ms 43.995 ms 44.684 ms]
                        change: [-78.833% -78.526% -78.173%] (p = 0.00 < 0.05)
                        Performance has improved.

computing cells_and_kzg_proofs - NUM_THREADS: Multi(32)
                        time:   [49.036 ms 50.404 ms 52.169 ms]
                        change: [-76.070% -75.382% -74.463%] (p = 0.00 < 0.05)
                        Performance has improved.

Note: that the single threaded version has been improved because we the fft algorithm was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant