feat!: add compile time flags to disable rayon #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Aug 23, 2024
Comment on lines
25
to
26
| singlethreading = ["bls12_381/blst-no-threads"] | ||
| multithreading = ["maybe_rayon/multithreading"] |
There was a problem hiding this comment.
Probably should standardize this to single-thread, multi-thread
kevaundray
commented
Aug 23, 2024
kevaundray
commented
Aug 23, 2024
|
|
||
| impl DASContext { | ||
| #[cfg(feature = "multithreading")] | ||
| pub fn with_threads( |
There was a problem hiding this comment.
rename this to new so that when users switch from single to multithread, they just need to modify the number of parameters
kevaundray
commented
Aug 23, 2024
| thread_pool: Arc<ThreadPool>, | ||
| pub prover_ctx: ProverContext, | ||
| pub verifier_ctx: VerifierContext, | ||
| } | ||
|
|
||
| #[cfg(feature = "multithreading")] | ||
| impl Default for DASContext { | ||
| fn default() -> Self { | ||
| let trusted_setup = TrustedSetup::default(); | ||
| const DEFAULT_NUM_THREADS: ThreadCount = ThreadCount::Single; |
There was a problem hiding this comment.
Might make sense to make the default SensibleDefault and then have that use the global threadpool
There was a problem hiding this comment.
In terms of defaults, single-thread, global threadpool and then a feature flag for local threadpool with threadcount might be the best, or just ask users to import threadpool in their own crate and set the threadpool amount themselves
kevaundray
changed the title
kevaundray
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.