Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Make test_anyof work #12

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Tests: Make test_anyof work #12

merged 1 commit into from
Dec 21, 2023

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Dec 19, 2023

About

Just fixes a test case after recent changes.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (6b44b8d) 82.12% compared to head (6c9ea1f) 85.00%.

❗ Current head 6c9ea1f differs from pull request most recent head dbf64ad. Consider uploading reports for the commit dbf64ad to get more accurate results

Files Patch % Lines
target_cratedb/sqlalchemy/vector.py 72.22% 15 Missing ⚠️
target_cratedb/sinks.py 37.50% 10 Missing ⚠️
target_cratedb/connector.py 83.33% 6 Missing ⚠️
target_cratedb/tests/test_standard_target.py 94.54% 6 Missing ⚠️
target_cratedb/sqlalchemy/patch.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   82.12%   85.00%   +2.87%     
==========================================
  Files           7        7              
  Lines         677      680       +3     
==========================================
+ Hits          556      578      +22     
+ Misses        121      102      -19     
Flag Coverage Δ
main 85.00% <83.89%> (+2.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl requested review from seut, matriv and surister December 19, 2023 00:59
@amotl amotl marked this pull request as ready for review December 19, 2023 00:59
@amotl amotl force-pushed the harmonize-sqlalchemy branch from 74296f7 to ab563dc Compare December 21, 2023 19:37
Base automatically changed from harmonize-sqlalchemy to main December 21, 2023 19:46
@amotl amotl merged commit 14cf7c2 into main Dec 21, 2023
2 checks passed
@amotl amotl deleted the tests-2 branch December 21, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant