Improve write operations to be closer to target-postgres
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
write-strategy
branch
6 times, most recently
from
2d56d58 to
2765f24
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage ? 83.47%
=======================================
Files ? 7
Lines ? 714
Branches ? 0
=======================================
Hits ? 596
Misses ? 118
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
force-pushed
the
write-strategy
branch
from
2765f24 to
4c8c2c4
Compare
amotl
force-pushed
the
harmonize-sqlalchemy
branch
from
74296f7 to
ab563dc
Compare
Meltano's `target-postgres` uses a temporary table to receive data first, and then update the effective target table with information from that. CrateDB's `target-cratedb` additonally offers the possibility to also write directly into the target table, yielding speed improvements, which may be important in certain situations. The environment variable `MELTANO_CRATEDB_STRATEGY_DIRECT` controls that behavior. - `MELTANO_CRATEDB_STRATEGY_DIRECT=true`: Directly write to the target table. - `MELTANO_CRATEDB_STRATEGY_DIRECT=false`: Use a temporary table to stage updates. Note: The current default value is `true`, effectively short-cutting the native way of how Meltano handles database updates. The reason is that the vanilla way does not satisfy all test cases, yet.
amotl
force-pushed
the
write-strategy
branch
from
4c8c2c4 to
9226d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Meltano's
target-postgresuses a temporary table to receive data first, andthen update the effective target table with information from that.
CrateDB's
target-cratedbadditonally offers the possibility to also write directly intothe target table, yielding speed improvements, which may be important in certain
situations.
Details
The environment variable
MELTANO_CRATEDB_STRATEGY_DIRECTcontrols that behavior.MELTANO_CRATEDB_STRATEGY_DIRECT=true: Directly write to the target table.MELTANO_CRATEDB_STRATEGY_DIRECT=false: Use a temporary table to stage updates.Note: The current default value is
true, effectively short-cutting the nativeway of how Meltano handles database updates. The reason is that the vanilla way
does not satisfy all test cases, yet.
References
The last step of the
upsertprocedure uses anUPDATE ... FROMstatement, which needs to be emulated per Python code, because CrateDB
does not provide that feature yet.
UPDATE ... FROMstatements crate/crate#15204