Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SQLAlchemy FloatVector type implementation #14

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Dec 19, 2023

About

Improved type support for FloatVector.

@amotl amotl force-pushed the write-strategy branch 5 times, most recently from 2765f24 to 4c8c2c4 Compare December 19, 2023 03:08
@amotl amotl force-pushed the vector-type branch 2 times, most recently from afe41fb to 5c30efc Compare December 21, 2023 01:15
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (14cf7c2) 85.00% compared to head (5c30efc) 83.38%.
Report is 1 commits behind head on main.

❗ Current head 5c30efc differs from pull request most recent head 4b0d9e6. Consider uploading reports for the commit 4b0d9e6 to get more accurate results

Files Patch % Lines
target_cratedb/sqlalchemy/vector.py 48.00% 26 Missing ⚠️
target_cratedb/tests/test_standard_target.py 84.34% 18 Missing ⚠️
target_cratedb/connector.py 77.77% 8 Missing ⚠️
target_cratedb/sinks.py 92.98% 4 Missing ⚠️
target_cratedb/sqlalchemy/patch.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   85.00%   83.38%   -1.62%     
==========================================
  Files           7        7              
  Lines         680      710      +30     
==========================================
+ Hits          578      592      +14     
- Misses        102      118      +16     
Flag Coverage Δ
main 83.38% <79.49%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl requested review from seut, matriv and surister December 21, 2023 01:35
@amotl amotl marked this pull request as ready for review December 21, 2023 01:35
Base automatically changed from write-strategy to main December 21, 2023 19:55
@amotl amotl merged commit 582b512 into main Dec 21, 2023
2 checks passed
@amotl amotl deleted the vector-type branch December 21, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants