Switch to new SQLAlchemy dialect for CrateDB #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the `FloatVector` SQLAlchemy type.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 86.11% 88.87% +2.75%
==========================================
Files 7 6 -1
Lines 713 665 -48
==========================================
- Hits 614 591 -23
+ Misses 99 74 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
commented
Dec 21, 2023
Comment on lines
97
to
+98
| "meltanolabs-target-postgres@ git+https://github.com/singer-contrib/meltanolabs-target-postgres.git@pgvector", | ||
| "sqlalchemy-cratedb[vector]@ git+https://github.com/crate-workbench/sqlalchemy-cratedb@amo/type-float-vector", |
There was a problem hiding this comment.
Of course, both of them need to be released before a serious GA release of meltano-target-cratedb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The new SQLAlchemy dialect for CrateDB includes the
FloatVectortype. This patch intends to validate that everything works well, and removes the previous implementation, which has been conceived here.References
FLOAT_VECTORdata type andKNN_MATCHfunction crate/sqlalchemy-cratedb#9