Add support for container types ARRAY, OBJECT, and FLOAT_VECTOR #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 78.10% 80.11% +2.01%
==========================================
Files 6 7 +1
Lines 548 679 +131
==========================================
+ Hits 428 544 +116
- Misses 120 135 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
force-pushed
the
types-1
branch
5 times, most recently
from
59f7b71 to
973b498
Compare
amotl
force-pushed
the
types-1
branch
2 times, most recently
from
b0aa3a8 to
3ddc350
Compare
amotl
commented
Dec 16, 2023
README.md
Outdated
| ``` | ||
|
|
||
| When installing the package using the Meltano's project definition, this | ||
| would probably the right way to write it down, but it hasn't been verified |
There was a problem hiding this comment.
Suggested change
| would probably the right way to write it down, but it hasn't been verified | |
| would probably be the right way to write it down, but it hasn't been verified |
| 'importlib-resources; python_version < "3.9"', | ||
| "meltanolabs-target-postgres==0.0.9", | ||
| 'importlib-resources; python_version < "3.9"', # "meltanolabs-target-postgres==0.0.9", |
There was a problem hiding this comment.
That's apparently a rendering glitch by pyproject-fmt.
What I wrote down, to signal that meltanolabs-target-postgres was only hooked off temporarily, was:
'importlib-resources; python_version < "3.9"',
# "meltanolabs-target-postgres==0.0.9",
pyproject-fmt was so kind to fold the comment next to the previous line ;]. Is it legit? This one might be related:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This patch brings in support for discovering/processing container data types, like CrateDB's ARRAY, OBJECT, and FLOAT_VECTOR. A significant portion of the code will need to be upstreamed to crate-python in a subsequent iteration, in order to improve the CrateDB SQLAlchemy dialect beyond this specific adapter implementation.
References
verify_schemaMeltanoLabs/target-postgres#250pgvector[NAIVE] MeltanoLabs/target-postgres#251