Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Use Chromium instead of PhantomJS with Karma testing #831

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Tests: Use Chromium instead of PhantomJS with Karma testing #831

merged 1 commit into from
Jan 12, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 12, 2024 •
edited
Loading

About

PhantomJS is deprecated since ages.

On the NPM registry, the most recent release of PhantomJS, phantomjs-prebuilt, is 6 years old already.

References

@amotl amotl added dependencies Pull requests that update a dependency file enhancement labels Jan 12, 2024
@amotl amotl marked this pull request as ready for review January 12, 2024 04:51
@amotl amotl requested review from matriv and removed request for matkuliak January 12, 2024 04:59
@amotl amotl mentioned this pull request Jan 12, 2024
Merged
@amotl amotl merged commit 42fff0d into main Jan 12, 2024
5 checks passed
@amotl amotl deleted the amo/phantomjs-to-chromium branch January 12, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matriv matriv matriv approved these changes

@surister surister surister approved these changes

@hlcianfagna hlcianfagna hlcianfagna approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove PhantomJS?
4 participants
@amotl @matriv @surister @hlcianfagna