-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Move tutorial-like content and references to cratedb-guide #82
Conversation
fbff4c9
to
7098972
Compare
docs/conf.py
Outdated
@@ -22,5 +22,8 @@ | |||
html_static_path = ['_static'] | |||
|
|||
|
|||
intersphinx_mapping["guide"] = ('https://cratedb-guide--29.org.readthedocs.build/', None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, 7098972 needs to be removed again before merging. It is only here to demonstrate everything fits together well, by making CI succeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CrateDB Guide has been published, and this workaround has been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this complete repository obsolete after the migrations and can be archived completely? If so, I'd suggest to not remove stuff with PR's but archive the complete repository afterwards.
The repository isn't obsolete. It carries all the content visible at https://cratedb.com/docs/crate/clients/. We can think about further refactoring on subsequent iterations. |
7098972
to
b77d02a
Compare
b77d02a
to
017168f
Compare
About
This patch refactors all the tutorial-like content and references to the new cratedb-guide documentation section.
Details
Because of followup cross-linking, this patch depends on the other patch to be integrated beforehand. Currently, it will fail on CI.