JWT refactor #227
Open
JWT refactor #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncombe
force-pushed
the
jc/jwt-refactor
branch
9 times, most recently
from
e8085fd
to
f6ff581
Compare
joncombe
force-pushed
the
jc/jwt-refactor
branch
from
f6ff581
to
7243240
Compare
alexdametto
approved these changes
Nov 18, 2024
| @@ -1,10 +1,4 @@ | |||
| export enum ConnectionStatus { | |||
There was a problem hiding this comment.
Good job with this refactor, there were 2 of almost the same type. Thanks!
|
|
||
| const getSchemaTableColumns = () => { | ||
| const schemaTableColumnsParsed = schemaTableColumnMock.rows.map( | ||
| const schemaTableColumnsParsed = useSchemaTreeMock.rows.map( |
There was a problem hiding this comment.
Don't know if it's the same mapping but if it is we could export the postFetch method and use it here just to avoid code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
JWTManager.GCContextProvideris no longer needed and have been removed.SchemaTreeContextProvideris no longer required and has been removed.Checklist
CHANGES.md.