Data type converter: Exercise None conversion

crate · Sep 7, 2022 · 1410547 · 1410547
1 parent b21c38e
commit 1410547
Showing 1 changed file with 18 additions and 7 deletions.
diff --git a/src/crate/client/test_cursor.py b/src/crate/client/test_cursor.py
@@ -58,7 +58,7 @@ def test_execute_with_converter(self):
         # Use the set of data type converters from `DefaultTypeConverter`
         # and add another custom converter.
         converter = Cursor.get_default_converter()
-        converter.set(CrateDatatypeIdentifier.BIT, lambda value: int(value[2:-1], 2))
+        converter.set(CrateDatatypeIdentifier.BIT, lambda value: value is not None and int(value[2:-1], 2) or None)
 
         # Create a `Cursor` object with converter.
         c = conn.cursor(converter=converter)
@@ -68,18 +68,29 @@ def test_execute_with_converter(self):
         conn.client.set_next_response({
             "col_types": [4, 5, 11, 25],
             "cols": ["name", "address", "timestamp", "bitmask"],
-            "rows": [["foo", "10.10.10.1", 1658167836758, "B'0110'"]],
+            "rows": [
+                ["foo", "10.10.10.1", 1658167836758, "B'0110'"],
+                [None, None, None, None],
+            ],
             "rowcount": 1,
             "duration": 123
         })
 
         c.execute("")
-        result = c.fetchone()
+        result = c.fetchall()
         self.assertEqual(result, [
-            'foo',
-            IPv4Address('10.10.10.1'),
-            datetime(2022, 7, 18, 18, 10, 36, 758000),
-            6
+            [
+                'foo',
+                IPv4Address('10.10.10.1'),
+                datetime(2022, 7, 18, 18, 10, 36, 758000),
+                6,
+            ],
+            [
+                None,
+                None,
+                None,
+                None,
+            ],
         ])
 
         # When removing the converters, all values are forwarded 1:1.