Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust badges, bump SQLAlchemy test version and add "workflow_dispatch" #396

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 23, 2021

Hi there,

this is just a minor update which refreshes the badges displayed within README.rst. However, its main purpose was to investigate why CI tests would not run on #395.

  • Adjust and add some badges to README.rst.
  • For covering the most recent SQLAlchemy 1.3 release, bump CI to use SQLAlchemy version 1.3.23.
  • Also, enable listening to workflow_dispatch events in order to be able to trigger workflows manually from the UI.

With kind regards,
Andreas.

@amotl amotl requested a review from a team February 23, 2021 17:18
@amotl amotl force-pushed the amo/ping branch 2 times, most recently from 518f6ba to 635601d Compare February 23, 2021 17:25
@amotl
Copy link
Member Author

amotl commented Feb 23, 2021

to investigate why tests on GitHub Actions would not run?

image

-- https://discourse.julialang.org/t/compathelper-workflows-disabled-after-60-days-of-inactivity/48870


I pressed the button in order to re-enable that workflow again.

@amotl amotl force-pushed the amo/ping branch 4 times, most recently from b0e8ac6 to c72e158 Compare February 23, 2021 17:43
@amotl amotl changed the title Documentation: Revamp badges in README.rst Documentation: Revamp badges and bump SQLAlchemy for test coverage Feb 23, 2021
@amotl amotl changed the title Documentation: Revamp badges and bump SQLAlchemy for test coverage Revamp badges and bump SQLAlchemy for test coverage Feb 23, 2021
@amotl amotl changed the title Revamp badges and bump SQLAlchemy for test coverage Adjust badges, bump SQLAlchemy test version and add "workflow_dispatch" Feb 23, 2021
- Adjust and add some badges to README.rst.
- For covering the most recent SQLAlchemy 1.3 release, bump to
  SQLAlchemy version 1.3.23.
- Also, enable listening to "workflow_dispatch" events in order to be
  able to trigger workflows manually from the UI.
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amotl amotl merged commit 3fa42ca into master Feb 24, 2021
@amotl amotl deleted the amo/ping branch February 24, 2021 11:03
@amotl
Copy link
Member Author

amotl commented Feb 24, 2021

Its main purpose was to investigate why CI tests would not run on #395.
Enable listening to workflow_dispatch events in order to be able to trigger workflows manually from the UI.

Unfortunately, while this will enable us to invoke workflows from the UI on branches within this repository now, one can not invoke the workflow again on a pull request branch.

So, things like [1] might enable that feature through trigger commands as we know from Jenkins [2].

[1] https://github.com/marketplace/actions/pull-request-comment-trigger
[2] https://plugins.jenkins.io/github-pr-comment-build/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants