Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite #401

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Improve test suite #401

merged 5 commits into from
Mar 29, 2021

Conversation

amotl
Copy link
Member

@amotl amotl commented Mar 24, 2021

Hi there,

based on this patch, it becomes easier to selectively run parts of the test suite. This is important to me because the whole test suite is currently only able to be invoked exclusively on Linux.

With kind regards,
Andreas.

@seut
Copy link
Member

seut commented Mar 25, 2021

@amotl what about the test failures?

Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seut
Copy link
Member

seut commented Mar 25, 2021

Ok got it, test failures should be solved by #397.

src/crate/client/tests.py Outdated Show resolved Hide resolved
src/crate/client/tests.py Outdated Show resolved Hide resolved
@amotl amotl force-pushed the amo/test-suite-improvements branch from db8a8e4 to 6472212 Compare March 25, 2021 16:31
@amotl amotl requested a review from mfussenegger March 25, 2021 17:42
@amotl amotl force-pushed the amo/test-suite-improvements branch from 0e59669 to 8758f08 Compare March 25, 2021 18:32
This is the foundation to improve the situation later by adding support
for running CrateDB through Docker or other means.
- Send Content-Length header based on the encoded response body
- Reduce sleep time after starting the server thread
@amotl amotl force-pushed the amo/test-suite-improvements branch from 8758f08 to bfc41b5 Compare March 26, 2021 10:27
src/crate/client/tests.py Show resolved Hide resolved
@amotl amotl force-pushed the amo/test-suite-improvements branch from bfc41b5 to 3335961 Compare March 29, 2021 08:36
@amotl amotl merged commit 9c98db5 into master Mar 29, 2021
@amotl amotl deleted the amo/test-suite-improvements branch March 29, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants