Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup: Return TIMESTAMP columns as native Python datetime objects #437

Closed
wants to merge 23 commits into from
Closed

Followup: Return TIMESTAMP columns as native Python datetime objects #437

wants to merge 23 commits into from

Commits on Jul 25, 2022

  1. Changed the sql_path 

    This returns the data type of the columns in a query, to allow us to transform the dates from cratedb (long int) to python datetime
    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    312eb24 View commit details
    Browse the repository at this point in the history

  2. Transform dates from crate to python datetime 

    In execute(), transform the columns with type timestamp and timestamp without time zone to python datetime, this will correctly display dates in apache superset
    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    41a881d View commit details
    Browse the repository at this point in the history

  3. Datetime conversion implemented using map and generator

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    49076da View commit details
    Browse the repository at this point in the history

  4. Updated tests

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    c053da3 View commit details
    Browse the repository at this point in the history

  5. Using generators to work with large datasets

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    feebd45 View commit details
    Browse the repository at this point in the history

  6. fix

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    6566879 View commit details
    Browse the repository at this point in the history

  7. test

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    a38860b View commit details
    Browse the repository at this point in the history

  8. updated datetime transformation using generators and updated test cases

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    e4fa0fa View commit details
    Browse the repository at this point in the history

  9. cleaning debug prints

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    77b6550 View commit details
    Browse the repository at this point in the history

  10. Passing a generator of the flags instead of passing the list of values

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    ee77ec1 View commit details
    Browse the repository at this point in the history

  11. Removed tests

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    5b33589 View commit details
    Browse the repository at this point in the history

  12. updated conversion of timestamps

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    7e39244 View commit details
    Browse the repository at this point in the history

  13. Added pandas dependency

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    f750966 View commit details
    Browse the repository at this point in the history

  14. Changed pandas timestamp to python datetime && deleted pandas dependecy

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    e6facf3 View commit details
    Browse the repository at this point in the history

  15. fixed - E226 missing whitespace around arithmetic operator

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    e6887f4 View commit details
    Browse the repository at this point in the history

  16. Changed yield value

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    a8ffdc3 View commit details
    Browse the repository at this point in the history

  17. Validate date type in processors

    @Aymaru @amotl
    Aymaru authored and amotl committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1c46079 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Fix tests: 979e82a adjusted the timestamps in the test fixture data

    @amotl
    amotl committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    8ce9209 View commit details
    Browse the repository at this point in the history

  2. Fix tests: Use defined time zone when validating naive datetime objects 

    Otherwise, the values of the datetime objects will depend on the time
zone setting of the system, making it difficult to compare
deterministically.
    @amotl
    amotl committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    ccc00a1 View commit details
    Browse the repository at this point in the history

  3. Remove spurious print statement

    @amotl
    amotl committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    a8532c5 View commit details
    Browse the repository at this point in the history

  4. Fix error when using _both_ types=true and error_trace=true options

    @amotl
    amotl committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    2cc1b90 View commit details
    Browse the repository at this point in the history

  5. Polish datetime conversion implementation 

    - Naming things
- Slight structural changes
- Use iterator instead of generator for column type flagging
- Improve inline documentation
    @amotl
    amotl committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    f355164 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Use datetime.utcfromtimestamp

    @amotl
    amotl committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    3154d32 View commit details
    Browse the repository at this point in the history