Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing id: field #677

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add missing id: field #677

merged 1 commit into from
Nov 14, 2024

Conversation

aibaars
Copy link

@aibaars aibaars commented Nov 14, 2024

Summary of the changes / Why this is an improvement

Without id: analyze the steps.analyze.output values will be undefined:

sarif-id: ${{ steps.analyze.outputs.sarif-id }}
sarif-file: sarif-results/${{ matrix.language }}.sarif

Checklist

Copy link

cla-bot bot commented Nov 14, 2024

We require contributors to sign our Contributor License Agreement, and we don't have a signature for @aibaars. To enable us to review and merge your code, please sign the CLA. Once signed, please post a comment '@cla-bot check' for me to check again. Thanks!

@aibaars aibaars closed this Nov 14, 2024
@aibaars aibaars reopened this Nov 14, 2024
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a stack!

@amotl amotl merged commit 8c4de4d into crate:amo/improve-codeql Nov 14, 2024
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants